search

0blu / WinterspringLauncher

All in one launcher! Allows you to play on Everlook.org with 1.14 client without technical knowledge!
MIT License
135 stars 32 forks source link

[BUG] "HermesSettings" field in winterspring-launcher-config.json DOES NOT override HermesProxy.config #51

Closed gibeiro closed 1 year ago

gibeiro commented 1 year ago

Steps to reproduce

  1. In winterspring-launcher-config.json, fill "HermesSettings" for a item in the "KnownServers" list.
  2. Launch WinterspringLauncher.exe and "Start Game" with the desired server config.

Expectation

HermesProxy will run with the settings added in winterspring-launcher-config.json under the "HermesSettings" field.

  "KnownServers": [
    {
      "Name": "Sanctuary",
      "RealmlistAddress": "logon.sanctuarywow.com",
      "UsedInstallation": "Default 1.14.2 installation",
      "HermesSettings": {
        "RestPort": "8082"
      }
    }
  ]

In my case, I specify RestPort as 8082.

Outcome

HermesProxy runs with the default values from HermesProxy.config

image
0blu commented 1 year ago

Thanks for the report