0blu / WinterspringLauncher

All in one launcher! Allows you to play on Everlook.org with 1.14 client without technical knowledge!
MIT License
128 stars 28 forks source link

Relentless strikes bug on 1.14.2 #59

Open Cyanidexx opened 5 months ago

Cyanidexx commented 5 months ago

Hello. I would like to report a bug seen on 1.14.2 regarding the relentless strikes rogue talent. I will describe thoroughly tthe bug, so it can eventually be tracked adequately and stop being an advantage for rogues using 1.14.2 ( because yes, IT IS an advantage as you will see later).

FIrst things first, this bug happens on 1.14.2 version of the game, bundled with the 2.1.0 winterspring launcher and the 3.1.0 hermes proxy, all downloaded from the https://github.com/0blu/WinterspringLauncher/releases. I havent altered any settings.

Abilities used: cheapshot (40 energy, see below), backstab 60 energy, kidney shot 25 energy

Talents to notice:

1) dirty deeds: reduced the energy cost of cheapshot and garrote by 10. Two points here, so the total energy reduction is 20, which means that cheapshot costs 40 energy

2) relentless strikes: the finishing moves have 20% chance PER COMBO POINT to refund 24 energy. 1 combo point has 20% to refund 25 energy, 5 combo points have 100% chance to refuns 25 energy.

3) initiative (gives 25% chance to add an additional combo point when using cheapshot, garrote or ambush). Three points here takes us to 75% chance for 3 combo points when using cheapshot

Now i will explain a usual pvp opener, analyzing the energy needed and refunded, according to the rotation and talents. Notice that i start from 100 energy (aka no nightslayer set bonus or vigor talent)

Step 1: cheapshot 100-40=60 energy

Step 2: backstab 60-60=0+20 what is the +20? its the 20 energy that are restored by default every 2 sec. Literally you dont even see 0 energy, because the moment you press backstab, you are exactly 2 sec in the rotation (1 sec for the gcd of cheapshot and 1 sec for the gcd of backstab

So right now we have 4 combo points on our target (or 3 if the initiative didnt proc), 20 energy in our bar and we want to use kidney shot. We cannot use it yet, because it requires 25 energy, so we have to wait until the end of cheapshot duration (4 seconds), In those 4 seconds we get 40 energy back. Se, we go to step 3 as following:

Step 3: 20 (energy restored at the end of backstab)+20 (energy restored at the end of cheapshot)=40

KIDNEY SHOT (finishing move and for the sake of the bug analysis we will follow the fortunate scenario that it will restore 25 energy to us through the relentless strikes talent), so

40-25(kidney shot)+25(energy restored by relentless strikes talent)=40

At this point, we have 40 energy. However... this IS NOT the case on 1.14.2!

If you do the same rotation, with the same talents on 1.14.2, instead of having 40 energy in the end of the rotation, you will be rocketed to 65! But wait, how does this 65 happen? 65=40+25, so we have 25 EXTRA energy in the end of the rotation, meaning the relentless strikes talent on 1.14.2 restores 50 energy and not 25. Now, if you search the bug list, i have posted 3 times or so, a bug of the relentless strikes on 1.14 that relentless strikes was bugged again. It was working normally restoring 25 energy, but it made the next ability cost 25 energy more, which literally renders the talent useless. This talent is a cursed one!

Sorry for the wall of text that might got you tired, but this talent is a must have in every spec, either daggers, or swords, either pvp or pve and it should not be bugged at all, especially since it gives a certain advantage between the two game versions. Check it please and see what you can do. Thanks a lot in advance!