0ceal0t / JobBars

A plugin for XIVQuickLauncher which provides extra job bars
GNU Affero General Public License v3.0
45 stars 28 forks source link

Crashes with Jobbars + material UI on penumbra #175

Open DenL opened 2 years ago

DenL commented 2 years ago

I’ve seen other issues related to material ui so here I am making a report, apologies if not supported. Since 6.18 there have been crashes happening possibly related to some incompatibility. Disable either Jobbars or penumbra/mui, then the crashes stop happening. Crashes happen when loading into duty, going into combat, summoning chocobo etc. Also note that my dalamud is NOT on canary (my version ends with .31) so this is not a canary specific issue.

Dranni21312 commented 2 years ago

I can confirm. Especially after the 6.18 update, the game is crashing very frequently with both JobBars and MaterialUI enabled. Disabling JobBars prevents the game from crashing.

a42020 commented 2 years ago

Can confrim too, had to disable jobbars for my game to not crash.

Dark-Cr0w commented 2 years ago

I've been able to continuously replicate this crash by logging in, moving to a new instanced area (inn room to major city and vise versa for example) and activating an ability. I found out that with certain conditions, GCDs and oGDCs don't crash the game while the other does. It is specifically the gauges that crash the game form what I can tell so I focused on that. With the results below, I also had individual gauges not enabled but the but the feature gauges was enables (the one at the top was checked). If I turn off gauges it works fine with no crashes.

Here is what I have so far- All of these are replicated multiple times to make sure it's not just random.

Crash

log -> job bar hidden till unsheathed -> unsheath log -> oGCD log -> new area -> oGCD log -> job change -> new area -> oGCD

No Crash

log -> GCD log -> new area -> GCD log -> new area -> job change -> oGCD or GCD log -> job change -> new area -> GCD log -> job change -> oGCD or GCD

Hope this helps in someway.

nyxalteria commented 2 years ago

can also confirm im having this issue

0kie commented 2 years ago

I can confirm the issue persists even after the update I have the crashes even If I turn off gauges

0ceal0t commented 2 years ago

@Dark-Cr0w if you get chance, could you upload a screenshot of your gauges and jobbars settings, as well as what zone/job/ogcds are causing the crashes. I'm having trouble replicating it so any information would be appreciated.

Also maybe the log output in %appdata%/XIVLauncher/dalamud.log?

0kie commented 2 years ago

I was able to reproduce it 4 more times doing the exact same steps, unfortunately dalamud.log is empty

in the lavender beds on a striking dummy, without changing zones or jobs, just after I logged in I did: energy drain > summmon carbuncle > ruin III + weave searing light and it crashed weirdly if I do the summoner opener right (summon carbuncle > ruin III into searing light weave > summon bahamut) it doesn't crash

I did it with only jobbars, penumbra and materialui installed. I have gauges on with different positions for each job (but it crashes even if I disable gauges) and buff tracking (I didn't try without buff tracking) earlier I had gauges linked to hp/mp bar, but it also happened with it linked to chat

Dranni21312 commented 2 years ago

I have managed to get the game crashing multiple times with JobBars enabled, but rarely has that produced any useful information in dalamud.log.

One stack trace I got the other day was:

Fatal error. System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt. at FFXIVClientStructs.FFXIV.Component.GUI.AtkImageNode.UnloadTexture() at JobBars.UI.UICooldownItem.Dispose() at JobBars.UI.UICooldown.Dispose() at JobBars.UI.UIBuilder.DisposeCooldowns() at JobBars.UI.UIBuilder.Dispose() at JobBars.JobBars.Dispose() at Dalamud.Plugin.Internal.Types.LocalPlugin.Dispose() at Dalamud.Plugin.Internal.PluginManager.Dispose() at Dalamud.Dalamud.DisposePlugins() at Dalamud.Game.Framework.HandleFrameworkDestroy(IntPtr) at Dalamud.Game.Framework.HandleFrameworkUpdate(IntPtr)

Dark-Cr0w commented 2 years ago

I've been testing it out in sharlayan, in between the inn and the main city, as well as the mist. For oGCDs I've normally noticed the crash with elusive jump, since when I log on DRG I use it to jump around. :P For the test, I was on WAR using Bloodwhetting for the oGCD and Overpower or Mythril Tempest as the GCD. I wasn't targeting anything either.

For dalamund.log, I've had the same problem as 0kie where there is no errors that show. (I'll attach it none the less) Also like 0kie, I turned off guages, buffs, and cooldowns. Buffs by itself crashed my game aswell and I turned off cooldowns just to be safe. Cursor and icons work fine still ^^

I also have my gauges split and set around my hotbars, usually looking like the example below. UI example Some settings Cooldowns also looked like this at one point buffs was also missing their icons but I forgot to capture that.

Considering this started happening with the 6.18 patch, and other plugins was having problems with their imGUI (is that how you say it?), I think maybe the same thing is happening here? With it crashing when I simply unsheath my weapon and cause the bars to draw on my screen/update?? (apologies for my phrasing) but im not sure how valid that theory since icons and cursors still works.

yordleIRL commented 2 years ago

Can confirm the method that @Dark-Cr0w used worked and I was able to reproduce a crash easily, I actually had a random crash happen while I was raiding in the DSR ultimate last night as well and I was just using simple oGCDs during that time.

Now this needs further testing but I might have a found a temporary fix: I tried reproducing the same steps to crash my game after unchecking the "Pulse diamond and arrow color" setting and restarting the game. Then I did all of the same steps to crash my game and I was unable to crash again afterwards, now I haven't gotten into a raid again or any other setting to test, but the crashes flat out stopped after unchecking that setting, so far.

The settings I use with Jobbars are the gauges and buff icons, while icons, cooldowns and cursor are disabled.

0kie commented 2 years ago

I just tested with "Pulse diamond and arrow color" disabled, still crashed

0ceal0t commented 2 years ago

For some reason, I haven't been able to get the game to crash. Could either of you message your complete dalamud.log and maybe config files to me on Discord (ocealot#4484)?

image

0ceal0t commented 2 years ago

also, could you try changing the UI elements. Something like this: image

luis86dr commented 2 years ago

Having the same issue. Even had the game crash when trying to disable the plugin. Hopefully you can pinpoint the bug because this plugin is amazing.

0kie commented 2 years ago

Some more info that I just remembered, idk if it is relevant or not.

I think jobbars was preventing some parts of materialui to load after 6.18 hotfix.

I would log in game and my gauges and cross-hotbar icons would be the default ones, it stopped from happening when I enabled "Wait for plugins before game loads" in dalamud settings, and this is when I first noticed the crashes.

I had this crash sometimes in 6.18 but it was less often than in 6.18 hotfix (or I was more lucky), now I can crash any time I do the steps I said in another message.

Also, I had the problem on #174 once, but instead of Feint it was Heavenscracker icon, it happened when I opened a fc chest and when this happened the game crashed without even using any skills, just by changing jobs. This one I have no idea how to reproduce, was seemingly random and happened only once.

0ceal0t commented 2 years ago

hmmm...that's a weird one. Can you test if the game crashes if you start with JobBars disabled/uninstalled (either removing it from /installedPlugins or disable then restart), and then re-enable it after you have logged in?

0kie commented 2 years ago

I had the game already open with jobbars uninstalled (and another dozens of plugins installed), I had already changed zones and did some duties so idk if this one counts, installed job bars, did ruin III > searing light, no crashes

I tried again after removing all my plugins other than materialUI and penumbra, logged into my character, installed jobbars, did energy drain > summon carbuncle > ruin III > searing light > summmon bahamut and then the whole rest of summoners rotation until summon phoenix with no crashes :)

logged out of my chracter without closing the game then logged back in again, game crashed in the loading screen before my character showed (not in character selection, after that, it showed the loading screen for lavender beds and then crashed when everything was supposed to show)

log attached only contains data after I removed all my other plugins other than the 3. dalamud.log .

0kie commented 2 years ago

Did it again with all my other plugins installed, no crashes after installing jobbars with the game already loaded.

Crashes instantly after logging off without closing the game and back in. (after going through the queue and starting to load the zone).

-------update------- it also crashes when I switch jobs if I install jobbars with the game already loaded

0ceal0t commented 2 years ago

I pushed v1.2.2.3, which hopefully fixes the issue

DenL commented 2 years ago

I reinstalled Penumbra and tested, and am sorry to report that I'm now crasing on startup. However my dalamud verison is now .35 so I'm not sure if it's a dalamud issue.

I removed penumbra and can launch game again. I tried reinstalling penumbra in-game and then relog to refresh UI. I don't crash this way, however any gauge graphic (both jobbars gauge and default ui gauges) is still using the game default gauge graphic as opposed to material UI graphic. Other graphics such as game panel backgrounds and icons are refreshed without issue.

If I were to restart the game with Penumbra installed, it would crash on startup until I manually removed either Penumbra/materialUI/jobbars.

Dranni21312 commented 2 years ago

I don't think that crash on game start is related to JobBars. I have been getting it since Penumbra upgrade.

nyxalteria commented 2 years ago

I don't think that crash on game start is related to JobBars. I have been getting it since Penumbra upgrade.

Someone brought this issue up on penumbra github and they said it was related to materia ui, some people brought it up on the materia ui discord to the plugin developer and they said it was jobbars, realistically I have no idea which one its coming from other than, jobbars works fine if I uninstall penumbra/materia ui, people have said if they uninstall jobbars then materia ui + penumbra works fine, but something is clashing with the plugins

edit: that being said I am no longer crashing. So whatever you did fixed it on my end.

edit 2: Yea just closed thee game and logged in a second time fine with materia ui/jobbars/penumbra enabled and it was fine

Dranni21312 commented 2 years ago

I don't think that crash on game start is related to JobBars. I have been getting it since Penumbra upgrade.

Someone brought this issue up on penumbra github and they said it was related to materia ui, some people brought it up on the materia ui discord to the plugin developer and they said it was jobbars, realistically I have no idea which one its coming from other than, jobbars works fine if I uninstall penumbra/materia ui, people have said if they uninstall jobbars then materia ui + penumbra works fine, but something is clashing with the plugins

I was one of those people. I've disabled JobBars since and had no issues. Then penumbra updated and my game crashed twice before even getting to the login screen, twice. Then it worked.

With penumbra / MUI / JobBars enabled, I still get the crash on startup once or twice, but once I make it to the login screen, the game does work just fine.

Dranni21312 commented 2 years ago

To add to this, I do believe that Dalamud was also contributing to this behavior, and this appears to have been fixed in 6.4.0.39 (RebuildFonts fix).

XiYuSuNv commented 2 years ago

Since the update with JobBars I haven't had any problems of the client crashing without notice like it was before. I went out of the game with JobBars already installed just to be sure. Went through dungeons, expert, and normal raids and see no issues. That is to say, I clicked "Update Plugins" and it said no updates were found. I saw the release of Penumbra t0.5.4.7 but still have v0.5.4.6 if that makes a difference. Thank you o/

DenL commented 2 years ago

With dalamud updated to .39 I'm no longer crashing on startup with JobBars+Penumbra+MaterialUI. However there would still be interminent crashes zoning into duty etc.

Naleisa commented 2 years ago

I believe it may still be an issue. I get no crashes, but the moment job bars is enabled I get crashes occasionally. I can provide dalamud.log next time it crashes if requested.

Suzuha2205 commented 2 years ago

I still get crashes too. Most of the time the moment I join a PF or on zone change/loading into a duty.

pawelglucklich commented 2 years ago

Still got crashes, most recent one was: ffxiv_dx11_gHUErlCYN9.png I got Penumbra with loaded MUI (but MUI is disabled). Also got jobbars. It usually crashes for me when I try to change jobs, sometimes in duty.

edit: After suggestion to disable cooldowns inside jobbars plugin, I no longer had any crashes during gameplay. I am crashing on closing game though. With that error ffxiv_dx11_CAmF0wCfa7.png.

PhyDoesStuff commented 2 years ago

I'm seeing the same crash on exit as pawelglucklich after disabling cooldowns within JobBars. It actually crashes twice, the stack trace is slightly different between the two. I missed copying the stack trace on the first crash, but I've attached the log of the second.

My game will stop responding as well when closing. I'll see either two crashes, then unresponsive (have to kill via task manager), or just the unresponsive behavior.

dalamud_appcrash.log

0ceal0t commented 2 years ago

sorry that the issues have persisted. I've got another update coming with the 6.2 patch which hopefully fixes these crashes

pawelglucklich commented 2 years ago

sorry that the issues have persisted. I've got another update coming with the 6.2 patch which hopefully fixes these crashes

Don't worry. I am happy to hear you trying to address issue. It is not like you are on our pay. Hopefully some of ours comments are helpful to you in someway.

0ceal0t commented 2 years ago

6.2 update is pushed (1.2.3.0). Let me know if the issue persists

pawelglucklich commented 2 years ago

after my first restart game didnt crash, been playing since couple hours so far no crashes. ;)

On Thu, 25 Aug 2022 at 19:18, ocealot @.***> wrote:

6.2 update is pushed (1.2.3.0). Let me know if the issue persists

— Reply to this email directly, view it on GitHub https://github.com/0ceal0t/JobBars/issues/175#issuecomment-1227550881, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4ST5VCVWC6YIZZK3GPHXTV26TGDANCNFSM53DUMANA . You are receiving this because you commented.Message ID: @.***>

DenL commented 2 years ago

Also have not run into any crashes. But occasionally when quitting game a dalamud crash error would pop up.

pawelglucklich commented 2 years ago

Worth mentioning is that I turned on cooldowns in jobbars and in game they work so far. Though I did encounter a crash on closing game (same dalamud crash thats textures related).

On Sat, 27 Aug 2022, 06:47 Dennis Lee, @.***> wrote:

Also have not run into any crashes. But occasionally when quitting game a dalamud crash error would pop up.

— Reply to this email directly, view it on GitHub https://github.com/0ceal0t/JobBars/issues/175#issuecomment-1229122746, or unsubscribe https://github.com/notifications/unsubscribe-auth/AN4ST5SUO6V77JJQB2ALWJDV3GMVNANCNFSM53DUMANA . You are receiving this because you commented.Message ID: @.***>