0ceal0t / JobBars

A plugin for XIVQuickLauncher which provides extra job bars
GNU Affero General Public License v3.0
50 stars 31 forks source link

DoT icon keeps flashing when out of combat #47

Closed AkazaRenn closed 3 years ago

AkazaRenn commented 3 years ago

image Is it by design? I find it a bit frustrating that the icon keeps flashing when I'm not doing anything.

0ceal0t commented 3 years ago

yes, this is intended. I'll add options to adjust it, however

AkazaRenn commented 3 years ago

@0ceal0t Thank you!

AkazaRenn commented 3 years ago

Oh, I just noticed it also flashes when I was targeting on my teammate. Would be nice to have it included in the change if possible, thanks again!

AkazaRenn commented 3 years ago

Hi @0ceal0t, just curious why this one is closed along with other issues, since it doesn't seem to be changed in 1.1.1.0. Is it put back for Endwalker or something?

0ceal0t commented 3 years ago

there are now options to change under what conditions the icon borders appear (including "Never"). You can also disable the icon replacement entirely

AkazaRenn commented 3 years ago

there are now options to change under what conditions the icon borders appear (including "Never"). You can also disable the icon replacement entirely

I tested all the four options, there doesn't seem to be one that allows the icon to "have dash border when in combat" while "not show dash border when out of combat". Same happened for MNK's Twin Snakes and Demolish, which appear available while they are actually not (out of combat, "Combo_And_Active" selected): image

Is it possible that we reset all the icon replacement status (or simply turn it off) when getting out of combat? That seems to make a bit more sense. It might also fix some issues happening when the icon status retain after changing jobs.

But still, thanks for the work, I defeinitely love it!