Do not redeem readmarkers for free reads

0chain / blobber

A storage provider (blobber) interface to the blockchain and consumers of storage.

Other

19 stars 23 forks source link

Do not redeem readmarkers for free reads #1166

Closed din-mukhammed closed 1 year ago

din-mukhammed commented 1 year ago

Changes

Readmarkers won't be redeemed if reading is free
Also removed readmarker handling from DownloadFile method, since redeeming readmarkers was moved to a separate handler

Fixes

Tests

Tasks to complete before merging PR:

[ ] Ensure system tests are passing. If not Run them manually to check for any regressions :clipboard:
[ ] Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
[ ] Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

0chain:
gosdk: https://github.com/0chain/gosdk/pull/1101
system_test:
zboxcli:
zwalletcli:
Other: ...

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (sprint-july-2@4239286). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@               Coverage Diff                @@
##             sprint-july-2    #1166   +/-   ##
================================================
  Coverage                 ?   25.77%           
================================================
  Files                    ?       80           
  Lines                    ?     9039           
  Branches                 ?        0           
================================================
  Hits                     ?     2330           
  Misses                   ?     6418           
  Partials                 ?      291

Flag	Coverage Δ
Unit-Tests	`25.77% <0.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

service-0chain commented 1 year ago

Manual system tests [cancelled] with the following config	config	value
tests skipped	false
system-tests	sprint-july-1
gosdk	free-reads
zboxcli	sprint-july-1
zwalletcli	sprint-july-1
0chain	sprint-july-1
blobber	free-reads
authorizer	staging
0box	staging
0dns	staging

service-0chain commented 1 year ago

Manual system tests [failure] with the following config	config	value
tests skipped	false
system-tests	sprint-july-1
gosdk	free-reads
zboxcli	sprint-july-1
zwalletcli	sprint-july-1
0chain	sprint-july-1
blobber	free-reads
authorizer	staging
0box	staging
0dns	staging