0chain / blobber

A storage provider (blobber) interface to the blockchain and consumers of storage.
Other
19 stars 23 forks source link

verify client in download handler #1378

Closed Hitenjain14 closed 6 months ago

Hitenjain14 commented 7 months ago

Changes

Fixes

Tests

Tasks to complete before merging PR:

Associated PRs (Link as appropriate):

codecov-commenter commented 7 months ago

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (cce361c) 14.40% compared to head (9f54632) 14.46%.

Files Patch % Lines
...et/blobbercore/handler/object_operation_handler.go 44.00% 11 Missing and 3 partials :warning:
.../0chain.net/blobbercore/handler/storage_handler.go 55.17% 11 Missing and 2 partials :warning:
code/go/0chain.net/blobbercore/handler/context.go 50.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## staging #1378 +/- ## =========================================== + Coverage 14.40% 14.46% +0.06% =========================================== Files 177 177 Lines 19859 19891 +32 =========================================== + Hits 2861 2878 +17 - Misses 16642 16653 +11 - Partials 356 360 +4 ``` | [Flag](https://app.codecov.io/gh/0chain/blobber/pull/1378/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=0chain) | Coverage Δ | | |---|---|---| | [Unit-Tests](https://app.codecov.io/gh/0chain/blobber/pull/1378/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=0chain) | `14.46% <56.92%> (+0.06%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=0chain#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.