0chain / blobber

A storage provider (blobber) interface to the blockchain and consumers of storage.
Other
19 stars 23 forks source link

Allocation ownership transfer is not synced from 0chain #728

Open peterlimg opened 2 years ago

peterlimg commented 2 years ago

Related issue https://github.com/0chain/gosdk/issues/765

cnlangzi commented 2 years ago

@peterlimg all allocation changes should be synced from blockchain. eg size, write_price, read_price...etc

lpoli commented 2 years ago

@peterlimg @cnlangzi What should be done to this issue?

boddumanohar commented 1 year ago

@peterlimg @cnlangzi can you please give a brief overview on what should done as a part of this ticket?

peterlimg commented 1 year ago

@boddumanohar first, we need to confirm if this bug still exist. So after transferring an allocation's ownership, check if the new owner has the CURD rights? and if how about the old owner.

Second, if the bug still exists, then we will need to check what we can do to fix the issue, most likely as @cnlangzi said above, it is because the ownership data hasn't been sync from 0chain, so perhaps, what we can do are:

Another way is to do whole allocations synching periodically, but that may use a lot of resources and cause performance issue as each blobber could have a lot of allocations need to update.

stewartie4 commented 1 year ago

@peterlimg just checking if this is still a valid issue, we still see flaky behaviour/periodic test failures

boddumanohar commented 1 year ago

@stewartie4 yes, I've validated and the issue still exists. At the moment, @lpoli is working on it. As is somewhat related to his Writemarker modification PR.

The problem is with respect to write maker signature verification. And the associated discussion can be followed here: https://0chain.slack.com/archives/C01U94VF56Y/p1668931208557289

Hitenjain14 commented 1 year ago

@peterlimg this function https://github.com/0chain/blobber/blob/staging/code/go/0chain.net/blobbercore/handler/storage_handler.go#L41 , updates the allocation right , if yes can we just call this function when zbox cli send the update request with txnhash of update owner transaction .

dabasov commented 1 year ago

postponed