0chain / zwalletcli

A client CLI using GoSDK to interface the blockchain, and smart contracts for interest, lock, stake, and vesting
Other
21 stars 16 forks source link

Feature: synchronize DEX bridge interface change #298

Closed YarikRevich closed 1 year ago

peterlimg commented 1 year ago

@YarikRevich seems we haven't updated the gosdk

YarikRevich commented 1 year ago

Tests fail because automatically there gets chosen staging branch, which does not have requested changes. Firstly we need to merge PR in gosdk(even if zwalletcli build fails there) and then merge this one

peterlimg commented 1 year ago

We need to update the gosdk to the specific branch here to see if all could work well and pass the system tests. Otherwise merging gosdk directly could cause unexpected issues and break others.

YarikRevich commented 1 year ago

That's exactly what I've done. Custom branch commit is used for gosdk. CI envorinment replaces it with staging for tests, so they fail

peterlimg commented 1 year ago

Please check the go.mod cause I don't see any changes for gosdk there, perhaps you forget to commit.

YarikRevich commented 1 year ago

Exactly! You are right, forgot to push the commit.

service-0chain commented 1 year ago
Manual system tests [failure] with the following config config value
tests skipped false
system-tests
gosdk NOT OVERRIDDEN
zboxcli
zwalletcli feature/update-interface
0chain
blobber
authorizer
0box
0dns
YarikRevich commented 1 year ago

Skipping tests because of the cyclic dependency with gosdk, which blocks the merge of the PR