0chain / zwalletcli

A client CLI using GoSDK to interface the blockchain, and smart contracts for interest, lock, stake, and vesting
Other
21 stars 16 forks source link

[FEATURE] Add validation to threshold param on createmswallet to avoid panic #49

Closed stewartie4 closed 2 years ago

stewartie4 commented 3 years ago

on staging, zwallet cli dies with a panic when calling createmswallet with a threshold of 0 image

zwallet cli dies with a panic when calling createmswallet with a threshold of -1 image

Solution: Add validation to threshold param to error out before trying to create a slice

cnlangzi commented 2 years ago

@shaktals it should be fixed on gosdk. could you raise an issue/pr on gosdk repo too?

shaktals commented 2 years ago

@cnlangzi done