Open oldlastman opened 10 years ago
Hi,
Sorry for my late reply I did not see it :/
Well I have just recieved a pull request and merged it, which fix the first issue. All entered data is now added to style.css
As for the second question I am not sure what you mean. What I do is I run the wp-bones command from within the wordpress theme folder, hence it is 'always deployed' if you mean deploy to another server, yes I would copy the fies manually.
I have seen other generators who create a git repo and so you can just do a git pull if you want to deploy elsewhere
hi! i made the pull request with my team :) so thanks for the merge
the second question. steps for production upload:
is this correct? or is better upload all files
I'm the one who should thank. It feels good when people find ones tool useful and wants to improve it.
If we go with the git approach we can exclude the files in question.
or could we make a grunt task to recompile everything into a global dist folder? On Sep 25, 2014 5:05 PM, "José Pardo Barceló" notifications@github.com wrote:
hi! i made the pull request with my team :) so thanks for the merge
the second question. steps for production upload:
- grunt dist
- upload to production server the theme files
- upload to production server the library/dist as library (this way because i dont want sass and other files in production server)
is this correct? or is better upload all files
— Reply to this email directly or view it on GitHub https://github.com/0dp/generator-wp-bones/issues/9#issuecomment-56832286 .
hey @oldlastman Do you think a grunt task like this: https://github.com/robwierzbowski/grunt-build-control could be used for a deployment plan?
wow that task it's pretty awesome :O it's a very good help in deploy ... i'm trying to play with that grunt task a little and i will comment about my results soon
Sounds good bro On Sep 27, 2014 1:29 PM, "José Pardo Barceló" notifications@github.com wrote:
wow that task it's pretty awesome :O it's a very good help in deploy ... i'm trying to play with that grunt task a little and i will comment about my results soon
— Reply to this email directly or view it on GitHub https://github.com/0dp/generator-wp-bones/issues/9#issuecomment-57049975 .
I'm a little confused on grunt dist. Its great that it copies in everything from /library but why not copy all the templates as well, effectively making the dist folder a ready to deploy theme? This makes sense to me but maybe there's a reason not to do this.
For example, I'm creating a dist folder at the top level in the theme like this:
copyto: {
dist: {
files: [
{cwd: '../../', src: ['**/*'], dest: '../../dist/'}
],
options: {
ignore: [
'../dist{,/**/*}',
'../../library/doc{,/**/*}',
'../../library/grunt{,/**/*}',
'../../library/scss{,/**/*}'
]
}
}
}
hey @mdmoore
That is really not a bad idea!
Maybe an option in the installer would be in place?
What do you think?
Feel free to do a pull request
hello, I install and use this generator and i have a couple of questions:
thanks
PD: sorry i'm not native