Add Photonics

[0exbot]

Pull request from @joamatab.

• title: Photonics
• head: Hardware
• desc: For photonic engineers, physicists and hobbyists.
• url: https://github.com/joamatab/awesome_photonics#readme
• stars: 127
• size: 82
• updated: 2022-10-14 17:52
• created: 2022-02-17 06:45
• pull: https://github.com/sindresorhus/awesome/pull/2189

add photonics resources https://github.com/joamatab/awesome_photonics

Add curated list For photonic engineers, physicists and hobbyists

[ boilerplate snipped ]

[0exbot]

@-joamatab on 2022-02-17 06:45 says: unicorn

[0exbot]

@-sindresorhus on 2022-02-17 07:24 says: Thanks for making an Awesome list! 🙌

It looks like you didn't read the guidelines closely enough. I noticed multiple things that are not followed. Try going through the list point for point to ensure you follow it. I spent a lot of time creating the guidelines so I wouldn't have to comment on common mistakes, and rather spend my time improving Awesome.

[0exbot]

@-Karneades on 2022-02-17 13:29 says: With the purpose of helping, went again over your repo and PR. One of the things is that every contributor should also review others. You could do it for my malware persistence list ;) and at least for another open PR.

• Your repo name should be changed according to the guidelines.
• You should describe the topic on top of the list and PR, not the list itself. Means, provide a description of what photonic is.
• The title of your entry should be title-cased and the URL to your list should end in #readme.
• This pull request has a title in the format Add Name of List. See examples in the guidelines.
• Then regarding the content of the list: there are a lot of missing description for the list entries.
• Trigger the lint check by opening a PR on your own list, see the errors which will be reported.
  • Run awesome-lint on your list and fix the reported issues.

[0exbot]

@-inoue0426 on 2022-02-22 20:10 says: You need to review at least two other PR and then write down the repository you reviewed like this, sindresorhus/awesome#-2034.

[0exbot]

@-joamatab on 2022-03-01 05:37 says: sounds good

I've reviewed https://github.com/sindresorhus/awesome/pull/2079 and https://github.com/sindresorhus/awesome/pull/2084

[0exbot]

@-Karneades on 2022-03-01 07:13 says:

sounds good

I've reviewed sindresorhus/awesome#-2079 and sindresorhus/awesome#-2084

What exactly did you review? :) You should leave a useful comment for improvement in open pull request. 2079 was already merged and closed in January and in 2084 you didn't comment at all :D You could do it for my malware persistence list PR ;) and at least for another open PR.

Regarding your PR: I commented multiple times on your PR, on the first one, and this one, and still various things are missing from the guidelines. Please check other PRs like this, so sindresorhus has less work himself.

[0exbot]

@-sindresorhus on 2022-06-05 10:10 says: Closing as the list is very far from being mergable and there's been no activity for a long time.