Open ebebbington opened 3 years ago
Love the latest commit message lol.
as of now, using canary (> 1.11.5) the infinite loop has gone, but revealed some more issues:
https://github.com/denoland/deno/issues/11286 https://github.com/denoland/deno/issues/11287
https://github.com/0kku/destiny/pull/17/commits/3647b7fcaf10dd06f991a3e774aba3e7e08cd500 does address both issues mentioned above, though of course it is a tiny workaround
3647b7f does address both issues mentioned above, though of course it is a tiny workaround
Could've just moved the cleanup method outside the class, since it's doing nothing with the instance anyway.
3647b7f does address both issues mentioned above, though of course it is a tiny workaround
Could've just moved the cleanup method outside the class, since it's doing nothing with the instance anyway.
Guess that's your preferred way then :P Is this approach something you're ok with?
Many changes:
deno fmt
is availablecompile.ts
file, in place of tsc, which uses 2 unstable api's.ts
extensions to imports forsrc
instead of.js
(to pass emit checks)examples_mod.ts
insidesrc
so we can properly emit the examples. Reason for this is, they aren't part of the dependency free formod.ts
so aren't included in the emit result. Due to this, we compileexamples_mod.ts
too. Not worth compiling each individual file instead because that takes a long time. As it stands, runningcompile.ts
is faster than tsc/webpackOf course it's completely down to you @0kku, as to whether you want to request changes, let along approve this PR, it's all welcomed and i completely understand
So how do you, Okku, and an end user use destiny now?
Good question edward
As the maintainer of Destiny, you would:
src/*.ts
files finenpm run compile
and deploy as you usually would this generates maps, declaration files and js files, so you can import it in the browser for js filesAs a user of Destiny:
TODO