0kku / destiny

A reactive UI library for JavaScript and TypeScript
Open Software License 3.0
53 stars 6 forks source link

chore: Convert to Deno #17

Open ebebbington opened 3 years ago

ebebbington commented 3 years ago

Many changes:

Of course it's completely down to you @0kku, as to whether you want to request changes, let along approve this PR, it's all welcomed and i completely understand

So how do you, Okku, and an end user use destiny now?

Good question edward

As the maintainer of Destiny, you would:

As a user of Destiny:

TODO

0kku commented 3 years ago

Love the latest commit message lol.

ebebbington commented 3 years ago

as of now, using canary (> 1.11.5) the infinite loop has gone, but revealed some more issues:

https://github.com/denoland/deno/issues/11286 https://github.com/denoland/deno/issues/11287

ebebbington commented 3 years ago

https://github.com/0kku/destiny/pull/17/commits/3647b7fcaf10dd06f991a3e774aba3e7e08cd500 does address both issues mentioned above, though of course it is a tiny workaround

0kku commented 3 years ago

3647b7f does address both issues mentioned above, though of course it is a tiny workaround

Could've just moved the cleanup method outside the class, since it's doing nothing with the instance anyway.

ebebbington commented 3 years ago

3647b7f does address both issues mentioned above, though of course it is a tiny workaround

Could've just moved the cleanup method outside the class, since it's doing nothing with the instance anyway.

Guess that's your preferred way then :P Is this approach something you're ok with?