Open 0liverkong opened 2 months ago
Thank you for reporting the issue.
This detection was never planned / implemented, and it was never mentioned in the documentation that such a message exists.
Moreover, implementing this detection feature requires way higher effort. Considering the user could detect the issue easily by observing the group list and checking the command history, this feature has a lower priority than what we have already implemented. Thus we will be marking this issue as "Not in Scope".
Team chose [response.NotInScope
]
Reason for disagreement: > This detection was never planned / implemented, and it was never mentioned in the documentation that such a message exists.
This is not true - in particular, functionality for detecting duplicates was implemented. The log book shows a "DuplicateCourseMateException" thrown. It has been detected by your code but went unhandled. This is entirely within the scope of your project, as 1. the group has created a custom error for it and 2. has used it elsewhere in your code, as seen from your AddMemberCommand.
To replicate:
Expected: either an error is thrown informing the user of the duplicate reference, or the duplicate reference is resolved and Alex is added normally.
Actual: No error message, hitting enter has no response