fix almost all rubocop and add rubocop on CI - Githubissues

0llirocks / cvss-suite

CvssSuite - This Ruby gem helps you to process the vector of the Common Vulnerability Scoring System.

https://cvss-suite.0lli.rocks

Other

23 stars 15 forks source link

fix almost all rubocop and add rubocop on CI #23

Closed fwininger closed 4 years ago

fwininger commented 4 years ago

Proposed changes

Fix almost all rubocop failure.

Configure rubocop on CI.

Configure the support of ruby >= 2.4

Types of changes

What types of changes does your code introduce to CvssSuite? Put an x in the boxes that apply

[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

[x] Unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)

Further comments

fix #19