0llirocks / cvss-suite

CvssSuite - This Ruby gem helps you to process the vector of the Common Vulnerability Scoring System.
https://cvss-suite.0lli.rocks
Other
23 stars 15 forks source link

Test for Integer#round_up #6

Closed adamrdavid closed 5 years ago

adamrdavid commented 5 years ago

Proposed changes

Hi Oliver,

Feel free to close this as it is very minor. I was about to do this: https://github.com/siemens/cvss-suite/pull/5 before I noticed it was already done :). This PR adds a very brief sanity check / documentation test for Integer#round_up.

It also adds .ruby-version to .gitignore so people who use a version manager don't accidentally commit it while developing.

Types of changes

What types of changes does your code introduce to CvssSuite? No code changes, only adds a test to existing code and updates .gitignore.

None of the below

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.

adamrdavid commented 5 years ago

Also wondering if https://github.com/siemens/cvss-suite/pull/5 will be included in a release anytime soon?

0llirocks commented 5 years ago

Hi @adamrdavid, I will take care of this and issue #5 sometime next week. I am also planning to release a new version next week including the changes regarding Integer and Fixnum.