0maru / twitter_login

MIT License
54 stars 54 forks source link

Only works with Chrome browser on Android device #65

Closed vanfresh closed 2 years ago

vanfresh commented 3 years ago

For other social media plugins, the <intent> is usually registered with a callback Activity from the plugin. But yours requires it to be registered with the MainActivity.

It seems to work on Android simulator but doesn't on real Android device. The problem is I think its conflicting with my app's Deep Linking.

Can you make it so the callback is registered in your own plugin intent?

vanfresh commented 3 years ago

Update:

Have to use Chrome as a default browser to work on Android. It should work with any browser.

0maru commented 3 years ago

@vanfresh If you use a non-conflicting intent, it should work fine. If this still conflicts, I would like to modify it to allow registration by activity.

Update: Have to use Chrome as a default browser to work on Android. It should work with any browser.

This plugin explicitly specifies Chrome custom tabs. This may cause it to not work if chrome is not enabled. I think this problem can be solved. Please wait a little longer.