Describe the bug
When launching Viper without an internet connection you may see various errors, related to your DNS not being set, and so on. This isn't very useful to a user.
To Reproduce
Steps to reproduce the behavior:
Disconnect your internet
Launch Viper
Errors occur
Expected behavior
A more descriptive alert box, or simply Viper launching as normal but without functionalities that require an internet connection. If we go for the latter requests.js should probably just return a cached version of the release notes and so on, even if it's supposed to have been refreshed. As to not have empty release notes, however we should still expect that a new user may not have an internet connection and so we should still display an error if no cache is found.
Screenshots
There's 3 identical error alerts, stemming from our 3 api.github.com requests (NS latest version, NS release notes and Viper release notes) in requests.js
Alystrasz
commented
2 years ago
Describe the bug When launching Viper without an internet connection you may see various errors, related to your DNS not being set, and so on. This isn't very useful to a user.
To Reproduce Steps to reproduce the behavior:
Expected behavior A more descriptive alert box, or simply Viper launching as normal but without functionalities that require an internet connection. If we go for the latter
requests.jsshould probably just return a cached version of the release notes and so on, even if it's supposed to have been refreshed. As to not have empty release notes, however we should still expect that a new user may not have an internet connection and so we should still display an error if no cache is found.Screenshots There's 3 identical error alerts, stemming from our 3
api.github.comrequests (NS latest version, NS release notes and Viper release notes) inrequests.js