0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
152 stars 21 forks source link

bug: Viper puts itself in french and I don't know how to change it #109

Closed Nawako0 closed 2 years ago

Nawako0 commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Install Viper on a french pc
  2. Close it, then open it again

Expected behavior Supposed to be in english, ask what language I want to use or at least let me change it in-app

Screenshots image

Version: 1.3.1

Additional Info My pc is in french but I like having the apps in english

Nawako0 commented 2 years ago

Alright I managed to change it by modifying the Properties file

0neGal commented 2 years ago

I'll keep this open, as I'll likely look into a way to force it in app, the reason this happens is it fetches your system language on startup and writes it to the settings file every time. However it's mostly low-priority...

Nawako0 commented 2 years ago

Yeah it doesn't even seem to be permanent. First time I tried it it worked, closed it, opened it, didn't work. Uninstalled, re-installed, edited Properties, opened it, didn't work! It's not that big a problem, I mean it's not for nothing my pc's in french, but it would still be appreciated if we could choose the language in the app.

0neGal commented 2 years ago

Generally Viper prioritizes the language in the settings file (viper.json), however after reading the settings file if an invalid language is set, or simply isn't set (first launch), it'll try to read the system. If it succeeds it writes it to the settings file.

However if it finds a valid language it'll use it, then it'll once again save the settings file with the system language, in case the user changed it. Leading to that behaviour... I'll implement a setting (when I got time) to disable Viper trying to read the systems language, and then let the user choose.

Nawako0 commented 2 years ago

Wow thanks! That's really appreciated!

0neGal commented 2 years ago

The upstream branch now has this implemented, meaning it'll be out in the next release!