0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
152 stars 21 forks source link

feat: Better Browser #125

Closed 0neGal closed 2 years ago

0neGal commented 2 years ago

This PR is meant to largely improve the mod browser, as currently it is very basic, however now it is far more functional, mod entries are now bigger, there's two entries per line instead of just one, there's now a button to directly view the README of the mod.

Along with that there's a new "Load more" button instead of the "Maximum packages has been loaded" message, which wasn't helpful, this button now allows you to load more than the max 50 packages.

There's also quite a bit of performance improvements, and general improvement that make the UI feel smoother, read the commit messages for more in-depth explanations of that.

TODO

As for localizations, there's quite a few strings... @Alystrasz @AA-Delta

"gui.mods.confirmdependencies": "This package has dependencies, shown below, clicking \"Ok\" will install the package and the dependencies.\n\n",

"gui.browser.view": "View",
"gui.browser.loadmore": "Load more...",
"gui.browser.endoflist": "All packages have been loaded.",

gui.browser.endoflist already existed but it has since been edited.

I also realized that in other languages Chromium likely doesn't call the "Ok" button in the prompts "Ok", since confirm() is a built-in function and it doesn't have options for changing it, it'd be neat if that also could be translated.

Both for the above strings but also general.invalidconfig

To see the prompt, if you've a Chromium-based browser, just run confirm() in the devTools or put javascript:confirm() in your URL bar. And it should give you the standard prompt, I don't suspect most Chromium-based browsers care to change the strings away from the default ones, so they should be the same between Chrome/Edge/Brave/etc

Worst case scenario run Viper with --debug and run confirm() in the devTools that open.

For Testing: There's a release specifically for this PR