0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

bug: Unknown error when attempting to remove a mod #176

Closed 1Phase1 closed 1 year ago

1Phase1 commented 1 year ago

Describe the bug I'm getting a notice of an unknown error every time I try to remove the Auto Matchmaking Mod with the "remove" button. I've tried reinstalling the mod in the find mods screen and then seeing if it could be removed, but it doesn't help and the same error as before occurs. I should mention, the mod was originally installed through the FlightCore launcher. When I uninstalled that launcher and switched to Viper, the mod carried over, and now I can't remove it.

To Reproduce Steps to reproduce the behavior:

  1. Install FlightCore, then install the Auto Matchmaking Mod through Flightcore. Uninstall Flightcore without removing the mod. (I'm including this step in case it's relevant to why the mod can't be removed)
  2. Navigate to the mods screen in the Viper launcher
  3. Locate the Auto Matchmaking Mod and press the "remove" button.
  4. The below screenshotted error will appear.

Expected behavior The mod is removed/uninstalled as it should be.

Screenshots Screenshot 2023-02-13 201241

Version: 1.12.0

GeckoEidechse commented 1 year ago

Auto Matchmaking Mod

That's the one made by TimeIsUnending? Cause I know that the mod already has some issues on its own (breaking some Northstar functionality if used).

Can you maybe share a screenshot of how your D:\Games on HDD\Steam\steamapps\common\Titanfall2\R2Northstar\mods folder? ^^

Also sidenote for @0neGal, path contains spaces, Viper handles that correctly, right? ^^

1Phase1 commented 1 year ago

Actually, I think you just unintentionally gave me the solution to the issue. I've been looking all over for the actual folder where the mods are installed. I didn't realize that the directory at the top of the error message leads to the folder where the mods are installed. I was following the other 2 listed directories that point to my C drive and finding nothing there. Should've realized the mods would be stored in the installation directory.

I found a folder in the Northstar mods folder listed with the Matchmaking Mod's name. Deleting that appears to have removed the mod.

Thanks a lot, I guess that's that solved.

GeckoEidechse commented 1 year ago

Glad you solved it. I'm just confused now why Viper even offered to remove a non-existing(?) mod in the first place...

@0neGal you don't use enabledmods.json for discovering installed mods, do you? :eyes:

0neGal commented 1 year ago

0neGal you don't use enabledmods.json for discovering installed mods, do you? 👀

I do not no, I'll have to look into this myself and see what's going wrong :p