search

0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

bug: Viper leaves a leftover `northstar.zip` in the Titanfall2 folder #180

Closed GeckoEidechse closed 1 year ago

GeckoEidechse commented 1 year ago

Describe the bug After downloading and extracting a new release, Viper never cleans up northstar.zip, cluttering the players install folder.

To Reproduce Steps to reproduce the behavior:

  1. Make sure you're on an outdated version of Northstar (or just delete NorthstarLauncher.exe)
  2. Launch Viper
  3. Viper will start update
  4. Now there's a leftover northstar.zip in the players Titanfall2 folder

Expected behavior Viper should clean up all temporary files after successful install.

Version: v1.7.0

Additional Info Not sure if the file is kept around for some caching reason maybe? ^^

0neGal commented 1 year ago

Not sure if the file is kept around for some caching reason maybe? ^^

The whole file is a remnant of when we downloaded the archive directly into the gamepath, unlike mod files which are downloaded into a temporary cache folder, and cleaned. This should've been removed a long time ago.

I'll have a look at getting this fixed/resolved in the upcoming release... :)

0neGal commented 1 year ago

This is now fixed in the latest release (v1.7.1), we now download to the same temporary folder used when downloading mods, aka one outside the gamepath.