0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

feat: Support EA Desktop better #183

Closed 0neGal closed 1 year ago

0neGal commented 1 year ago

This should make support for the EA Desktop App much better, as it now is also closed alongside Viper if the setting for it is enabled.

This however does mean the old localization strings aren't very accurate anymore, as they don't make any mention of the EA Desktop App, and so new strings are needed.

Closes #182

Changed localization strings

From:

"gui.settings.originkill.title": "Automatically quit Origin",
"gui.settings.originkill.desc": "When Viper exits, automatically quit Origin as well.",

To:

"gui.settings.originkill.title": "Automatically quit Origin and or EA Desktop",
"gui.settings.originkill.desc": "When Viper exits, automatically quit Origin and or EA Desktop as well.",

Languages

DxsSucuk commented 1 year ago

Instead of writing and or EA Desktop wouldn't it be better to use

Automatically quit Origin/EA Desktop

0neGal commented 1 year ago

Instead of writing and or EA Desktop wouldn't it be better to use

Automatically quit Origin/EA Desktop

Not exactly, "Origin/EA Desktop" mostly implies "Origin or EA Desktop", when it is in fact one or both. If you've Origin and EA Desktop open, both will be closed, if just one of them, then it's just that one.

Either way, it's mostly just for clarification :p

DxsSucuk commented 1 year ago

But EA Desktop does not allow Origins to be open? Doesn't it automaticly close Origins once you open it?

0neGal commented 1 year ago

Doesn't it automaticly close Origins once you open it?

I actually don't know, I don't have a Windows install available right now, and have yet to actually ever use the new EA Desktop App... :p

DxsSucuk commented 1 year ago

Well I am just talking out of memory but I remember EA Desktop showing a message "Closing Origins" when booting it up on the splash screen of it.