search

0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

Update platform detection #200

Closed 0xfadead closed 1 year ago

0xfadead commented 1 year ago

Instead of checking if the platform is Linux, it instead checks, if the platform is not Windows and displays a error message with the according platform.

0neGal commented 1 year ago

I don't think this is needed, it'd be preparing for a situation where someone would run Viper outside of the ways that we provide it. We only package it for Windows and Linux. And there are no plans to add support to any other platforms. The kind of person who'd even run a BSD OS is likely also the same kind of person who really doesn't need a mod manager for launching the game, if at all.

But were this to be implemented, then we'd also have to make sure process.platform is capitalized correctly and or even written correctly. Notably, on Linux it'll return to linux, and FreeBSD and OpenBSD will both be lowercase as well. And for macOS it'd be darwin

Unless there's something I've missed here, then I'll likely close this, but do feel free to let me know if that's the case.

0xfadead commented 1 year ago

Thank you for the quick reply! Your points are certainly valid, so I'll close this pull request with this comment.