search

0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

bug: Viper not properly detecting outdated mods? #204

Closed GeckoEidechse closed 1 year ago

GeckoEidechse commented 1 year ago

Describe the bug After purposefully installing an older version of the parkour mod Alystrasz-Parkour-0.1.1 and restarting Viper, it appears to not pick up that the installed mod is outdated and fails to show update button.

Further Viper keeps claiming that my ModSettings install is outdated. Checking the mod.json for that one shows version number 1.0.0 so I assume Viper is incorrectly using the mod.json version number to detect whether a Thunderstore mod is outdated.

To Reproduce Steps to reproduce the behavior:

  1. Install Alystrasz-Parkour-0.1.1 in packages/ dir I used the dev menu in FlightCore to achieve this.
  2. Launch Viper
  3. Go to mods tab
  4. Parkour mod does not say outdated

Expected behavior Viper should pick up that the installed parkour mod version is outdated.

Screenshots Parkour mod not showing Update button image

ModSettings showing Update button even though up-to-date image

Version: v1.8.1

0neGal commented 1 year ago

This was actually half already known to be a problem, and I intend to hopefully have it fixed by 1.8.2 :)

I didn't discover this actually being an issue due to my slightly unorthodox setup of mods and VPK patching, but found out about it not long after release...

0neGal commented 1 year ago

The two latest commits should fix this entirely.