search

0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

bug: unable to edit launch options after toggling mods #206

Open LittlePlanlessFool opened 1 year ago

LittlePlanlessFool commented 1 year ago

Describe the bug After toggling all mods, launch options can only be highlighted and deleted, not entered

To Reproduce Steps to reproduce the behavior:

  1. Go to Mods
  2. Click on "Toggle All"
  3. Click on either "Cancel" or "Ok"
  4. Open settings
  5. Click on "Launch options" text field

Expected behavior a cursor should appear so text can be entered

Version: Release 1.8.1

Additional Info restarting the app fixes this

LittlePlanlessFool commented 1 year ago

https://github.com/0neGal/viper/assets/91974061/6703c04b-d175-417c-b346-1e5b17c6ceda

not visible is the dialogue to confirm toggling the mods focusing another program also fixes this the same bug also affects the dialogue box "Retain files on update"

0neGal commented 1 year ago

I cant seem to reproduce this, at least on Linux, this may be a problem with Electron/Chromium as a whole, I'll possibly end up yanking out my very old and dusty install of Windows to confirm this, unless somebody else can confirm it being broken on Windows but not on Linux.

Though it may be possibly to work out a janky fix to this through .blur() and then .focus() on the input when the window loses and or regains focus?

Once again, further testing is needed here...

0neGal commented 11 months ago

Viper recently updated from Electron v22.0.0 to v22.3.21, and it may have fixed this, can you attempt to reproduce this bug in the latest version of Viper (v1.8.5)?

LittlePlanlessFool commented 11 months ago

Behaviour still persist in v1.8.5

0neGal commented 11 months ago

I had some hope, but thanks for testing anyway.

I'll consider updating to the latest Electron version at some point, albeit this is a low-priority bug so I won't invest time in that right now, as I'd have to test for any breaking changes between major Electron versions...

If anybody else can reproduce this reliably, especially on platforms other than Windows, then that'd be very helpful, I'll have a look at reproducing it myself whenever I get the time and ability to spin up a Windows installation.