search

0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

bug: Weird interactions for the "No such file or directory"... "R2Northstar\packages" error #209

Closed itscynxx closed 12 months ago

itscynxx commented 1 year ago

Describe the bug Many users in the Discord server have been confused with an error on Viper recently

When the mods directory exists but packages doesn't, Viper gives the error properly and hitting Install creates a packages folder, which fixes it.

When mods and packages both don't exist (or a clean install), Viper installs/reinstalls Northstar (as it should), but it then gives an error (while installing Northstar) saying that the packages folder can't be found. If you watch the directory while you install, this is because it first extracts the mods folder properly, then waits a bit before making the packages directory, causing it to trigger the "no packages directory" error before the folder gets made

To Reproduce Steps to reproduce the behavior:

  1. Install Viper
  2. Let Viper install Northstar (making sure it isn't already installed or at least the packages and mods directory don't exist)

Expected behavior Viper downloads Northstar without giving an error about a missing directory that in fact exists

Screenshots image image

Version: Newest, downloaded from https://0negal.github.io/viper/ right before testing

Additional Info Something that Viper does causes it to create the packages folder after the check is done, therefore causing it to freak out and think it doesn't exist, before creating the folder properly, and letting you play

0neGal commented 1 year ago

Actually, this has already been fixed in the latest version :)

itscynxx commented 12 months ago

it seems like it was tried to be fixed, but this was all tested on 1.8.3 image

0neGal commented 12 months ago

Huh, weird, I can't seem to reproduce this, as it seems fixed for me... If possible could you run Viper in a command prompt and copy the error in it's entirety, as it seems slightly cut off, which is a different bug entirely.

It just consists of typing the full path to the .exe in a command prompt and it'll work, let me know if you need further help with running it there.

itscynxx commented 12 months ago

This is the entirety of what it wrote, for reproducing make sure you remove at least both the mods and packages folder if you weren't doing that image

I also tried again while removing all other Northstar related files to make sure it wasn't something there, and it happened again, but just doing mods and packages removal lets you see the error come up before the folder appears in the directory

If this can't be replicated on your end, I can record a video showing it

0neGal commented 12 months ago

Ah, I think this might be a Windows thing (I'm a Linux user), can you try this portable .exe and see if it fixes it, if so I'll have a fix out soon.

itscynxx commented 12 months ago

Using the portable exe gave the same error

0neGal commented 12 months ago

Hmm, tried quickly to run it in a Windows VM, and I still, really cant find a way to reproduce this... very weird...

0neGal commented 12 months ago

While I don't think this'll fix it, it's worth a go, can you try and download and attempt to reproduce it with this build

itscynxx commented 12 months ago

oh, no that actually did it

no error

i will try a few more times to confirm it wasnt a one off thing

0neGal commented 12 months ago

Assuming that was the fix, then I'll be closing this, as this is now patched in v1.8.4, released moments ago.