0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
152 stars 21 forks source link

bug: Viper doesn't finish installing and gives errors #214

Open Zauzzx opened 1 year ago

Zauzzx commented 1 year ago

I tried to uninstall and reinstall viper and the progress bar for the installation doesn't get to the end and viper just launches all the sudden I am bombarded with error messages. image I don't know what I am doing wrong. Please help me.

EDIT: This problem only occurs when the northstar exe exists.

0neGal commented 1 year ago

Hmm that's weird, never seen this before and can't seem to find a way to reproduce, could you open your gamepath, then go into the R2Northstar folder, then open enabledmods.json in Notepad or any other text editor (if the file doesn't exist, just let me know), then copy paste the contents in here.

LoafOfLogAnd commented 1 year ago

I have this exact same bug I installed viper today and whenever I try to open the game path I get this. Edit: The enabledmods.json file just has "null" Edit2: I just deleted the null and left nothing and the messages stopped popping up! image

0neGal commented 1 year ago

I have this exact same bug I installed viper today and whenever I try to open the game path I get this. Edit: The enabledmods.json file just has "null" Edit2: I just deleted the null and left nothing and the messages stopped popping up!

Huh, that's unique, I suppose I'll have to implement some checking to enabledmods.json, it should always be formatted correctly unless some mod manager messed with it incorrectly, or for all I know, Viper is the one who's responsible for it. Either way, a fix should be made at some point, so thanks for reporting this...

LoafOfLogAnd commented 1 year ago

Also, I honestly have no idea what I am doing, but I noticed that when I deleted "null" and left nothing, it would go back again into the file and the bug would repeat itself every time I restarted Viper. So instead I replaced it with "true" (like I said idk what I am doing) and now the bug never bothers me, and Viper can still open the Northstar with no problems. Edit: This is all about the enabledmods.json thing.

0neGal commented 1 year ago

Likely Viper that's at fault then, wouldn't be a very hard thing to fix!

Foox-dev commented 8 months ago

I am having the same issue. Any fix?

0neGal commented 8 months ago

Very long time since I've looked at this issue and can't remember if I ever fixed this, and forgot to close here (in that case you're having a different issue)

If it's however identical in errors and all, could you try deleting the enabledmods.json file in the R2Northstar folder inside your game path. And see if that fixes it, and if not, open it with a text editor and simply write [] in it, and save.

Let me know if that fixes it, and which one of those fixed it...

Foox-dev commented 8 months ago

I did find a fix. The error happened because I previously installed the VTOL launcher for NorthStar. For some reason it left a lot of folders and extra files in the game path, which then effected Viper. Deleting those files fixed the issue

0neGal commented 8 months ago

Ah, I see, you wouldn't happen to remember the name of those folders and files? Would be nice to be able to auto detect it, and fix it automatically.

Foox-dev commented 8 months ago

I sadly don't. If you want I could try and replicate it again when I'm free. By the way, I know JavaScript (to a decent extent), and I would be interested to work on this.

0neGal commented 8 months ago

Feel free, I do think they might be two different issues, as the original bug in this issue was relating to enabledmods.json containing null for some reason, and I have confirmed, that issue is not fixed in the latest version, I also don't know if the initial write of null in the file is done by Viper or another mod manager.

But if you didn't touch that file, it's very possible you're dealing with a different issue.

But the original issue is actually quite easy to fix by itself (or that is, handling the file containing incorrect data), and frankly am surprised I never fixed it a long time ago.