search

0neGal / viper

Launcher+Updater for TF|2 Northstar
https://0negal.github.io/viper
GNU General Public License v3.0
151 stars 21 forks source link

Add percentage counter to update #220

Closed 0xfadead closed 8 months ago

0xfadead commented 9 months ago

What

Adds a percentage counter and shows complete size of update when downloading one. image

Why

It was suggested in the code and I find it to be quiet useful.

Notes

I am not a Javascript programmer, so my code may be very poorly written, simply because I do not know the language well.

Getting the size of the update introduces new error messages, which require localization.

0xfadead commented 9 months ago

I think it'd be better to get rid of the download size itself and replace it with percentages

I personally disagree, since when downloading you'd have no way of knowing the real size, which can, especially on slow internet connections, be a wildcard in terms of time spent downloading the update and may lead to frustration when updates arrive.

I would therefore suggest a compromise of the two approaches: When the complete size is known, it displays Downloading... [complete size] mb X% and when not Downloading... [received] mb

0neGal commented 9 months ago

I agree that knowing the size can be quite useful, but it just becomes quite cluttered in my opinion. Especially because the user might not know what Xmb means in Downloading... Xmb X%

Perhaps I should look into reworking the component for this completely, allowing for more content in it, without making it cluttered... An idea could also be to use the "Launch" button for the progress, making the text of the button be the progress, and the text below for extra information. We could then add a progress slider inside the "Launch" button as well, to give it a bit of "flair" if you will. This could then be re-used for extracting as well, as an example:

image

The 1/2 will be used to distinguish between the extracting of the update and downloading, so when extracting it'll become 2/2

0neGal commented 9 months ago

The latest commit has an implementation of the solution I suggested, along with excerpts from this PR to add the percentage to the download, do let me know if you think it suffices, and if not, any suggestions to change that.

0neGal commented 8 months ago

Due to the lack of response I'll be closing this, feel free to re-open if you missed this, and still would like to leave some feedback.

0xfadead commented 7 months ago

Ah sorry, I missed your replies. I haven't looked at my profile/notifications for a while. Thanks for implementing it!

Have a nice new year!