search

0no-co / GraphQLSP

TypeScript LSP plugin that finds GraphQL documents in your code and provides diagnostics, auto-complete and hover-information.
https://gql-tada.0no.co
MIT License
332 stars 13 forks source link

fix: deduplicate fragments when generating persisted document hash #342

Closed felamaslen closed 2 weeks ago

felamaslen commented 2 weeks ago

resolves #341

changeset-bot[bot] commented 2 weeks ago

🦋 Changeset detected

Latest commit: ef3f3c101757c4ce12b010d746bae4632bdb4e14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------------- | ----- | | @0no-co/graphqlsp | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

felamaslen commented 2 weeks ago

I'm not sure if you'd count this as a breaking change. It is really a bug fix, but it would mean that certain documents which previously passed npx gql-tada check will no longer pass.

JoviDeCroock commented 2 weeks ago

Would be good to add a changeset and double check the implementation of the CLI whether the ordering could be different. It's a patch

JoviDeCroock commented 2 weeks ago

The ClI impl feels a bit simpler with the seen set but comes down to the same thing so good to go https://github.com/0no-co/gql.tada/blob/main/packages/cli-utils/src/commands/generate-persisted/thread.ts

felamaslen commented 2 weeks ago

Yep was just about to say the same thing. Ordering is the same in each case.