refactor: Improve `print` performance - Githubissues

0no-co / graphql.web

The spec-compliant minimum of client-side GraphQL.

MIT License

74 stars 1 forks source link

refactor: Improve `print` performance #24

Closed kitten closed 6 months ago

kitten commented 6 months ago

Set of changes

Unrelated: Fix invalid type alias in src/ast.ts’ StringValueNode
Add new indentation logic without .replace
Replace .map + .join with mapJoin function
Fix nodes.SelectionSet not being reused in some places

Note: The benchmarks fluctuate. Sometimes the old code can reach >100K Hz, sometimes it can't.

Before

@0no-co/graphql.web  105,914.82  0.0088  0.2635  0.0094  0.0093  0.0115  0.0121  0.0858  ±0.32%    52958   fastest

After

@0no-co/graphql.web  127,397.56  0.0070  0.4896  0.0078  0.0077  0.0092  0.0097  0.0761  ±0.34%    63699   fastest

changeset-bot[bot] commented 6 months ago

🦋 Changeset detected

Latest commit: 12783195383291c73e5630be9d3781030245d3e6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | ------------------- | ----- | | @0no-co/graphql.web | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR