Closed naporin0624 closed 1 year ago
Nice catch!
I think I can see how I made this mistake. I think I wrote it as optional because of ObservableLike
for fromObservable
to make that type more flexible 🤔
Would you mind updating the return type here: https://github.com/0no-co/wonka/blob/990c8da89b2d6e5be3d5f8ca2bd79b2a3a9fb00c/src/observable.ts#L79
To something like { unsubscribe(): void }
please?
I think that'd help out a lot to keep fromObservable
flexible while making toObservable
more strict ✌️
ok! It took me a while, but I understand what you're saying and I'll fix it right away!
Thank you for creating a great lightweight library.
I have fixed the difference between proposal-observable and the closed type in subscription.
The following are subscription types for proposal-observable.
Current wonka subscription type.
Confirmed