search

0no-co / wonka

🎩 A tiny but capable push & pull stream library for TypeScript and Flow
MIT License
709 stars 29 forks source link

upgrade to bucklescript@8 #88

Closed Austaras closed 4 years ago

Austaras commented 4 years ago

fixes #85

Austaras commented 4 years ago

Since it will be a break change for TS/JS user, I suggest to release it as wona@5-alpha.0

BlueHotDog commented 4 years ago

hey, would love to get this merged. looking forword to upgrade to the latest BS.

kitten commented 4 years ago

Just gotten to taking a look at this and it's superb! Works perfectly 👏 Thanks for taking the time to get this done and opening a PR; I'll release this as v5.0.0-rc.0 since I don't expect there to be a lot of iteration and testing to get this out.

kitten commented 4 years ago

Alright, this should be published under the rc tag as 5.0.0-rc.0 https://github.com/kitten/wonka/releases/tag/v5.0.0-rc.0

BlueHotDog commented 4 years ago

Thank you. that fixed it. was able to upgrade to 8.1 without any issues.

On Thu, Jul 2, 2020 at 8:30 PM Phil Plückthun notifications@github.com wrote:

Alright, this should be published under the rc tag as 5.0.0-rc.0 https://github.com/kitten/wonka/releases/tag/v5.0.0-rc.0

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/kitten/wonka/pull/88#issuecomment-653134337, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABYQ46VPEQEFQXVJQABAJ3RZS73ZANCNFSM4OJ3ESCQ .

-- Danni Friedland +972-54-7764415