search

0perationPrivacy / VoIP

Web Base Telnyx/Twilio VoIP Interface enabling SMS, MMS and Voice calls using the providers API Keys and self-hosting the application.
https://VoIP.OperationPrivacy.com
GNU General Public License v3.0
246 stars 421 forks source link

Additional profile pulls assigned DID #45

Closed jvoiptel closed 3 years ago

jvoiptel commented 3 years ago

Platform: [Desktop or Mobile] Win10 Browser: [e.g. Firefox, Chrome, Safari, Brave] Edge App Version: [e.g v0.60-beta] v0.65.2-beta Provider: [Telnyx, Twilio, Both] Telnyx

Describe the bug

When adding a 2nd profile, I see an already assigned DID in the drop-down menu without even adding an API key

To Reproduce

  1. Go to 'Add New Profile'
  2. Click on 'Save.'
  3. Scroll down to 'Settings.'
  4. You will see previously assigned DID in drop down. You can even select it and Save successfully.

However, it will not work and do not expect it to work because it's already assigned to another profile.

Expected behavior I do not expect anything in the dropdown until a new API key is added. App also allows you to save it but I don't think that should be allowed.

Screenshots If applicable, add screenshots to help explain your problem. profile2

jvoiptel commented 3 years ago

Well, my observation was not that we're missing an API key as much as it's listing a DID that's already assigned to another profile. I think there's going to me confusing here because an API key can have multiple DIDs, but it doesn't seem like a DID can be assigned to multiple accounts (at least I don't think that's a good idea).

Problem I see the carrier support thus far is that each user of this app would need a Telnyx account. Since I manage many DIDs with SMS feature, I would prefer creating dedicated API keys which lists the DIDs they own. Not sure if Telnyx supports this but I can find out.

0perationPrivacy commented 3 years ago

Well, my observation was not that we're missing an API key as much as it's listing a DID that's already assigned to another profile. I think there's going to me confusing here because an API key can have multiple DIDs, but it doesn't seem like a DID can be assigned to multiple accounts (at least I don't think that's a good idea).

Problem I see the carrier support thus far is that each user of this app would need a Telnyx account. Since I manage many DIDs with SMS feature, I would prefer creating dedicated API keys which lists the DIDs they own. Not sure if Telnyx supports this but I can find out.

I understand this, I will address this in a fix. It's taking the list from a cache. But once you put in a new API key and press the button, it will refresh with an updated list of DIDs for that API. Right now it's just defaulting the dropdown to the last updated list. Will get it fixed soon. Until then, I'll keep this open. Thanks.

0perationPrivacy commented 3 years ago

fixed this, will push it out in an update with some other fixes tomorrow sometime. Then I'll close this.