search

0perationPrivacy / VoIPSuite-Mobile

Mobile App code for Android & iOS on React Native
https://voip.OperationPrivacy.com/
GNU General Public License v3.0
18 stars 5 forks source link

Custom ports not supported #33

Closed bugbountyguy closed 1 year ago

bugbountyguy commented 1 year ago

Hi,

My local instance is not using port 443 for https due to the need to port forward via my VPN and the app on my server using the environment variable for internal redirects (so can't just setup my docker container to 54830:443 I think? I can try, but still think this should be looked into either way). When inputting my URL + a port number, the login screen says "Incorrect URL". I'm guessing keyboardType="url" doesn't support ports for some weird reason, or it's something else.

0perationPrivacy commented 1 year ago

you can set port with the environment variabl PORT as mentioned in the wiki

The server will then run on that port. In your port forwarding rule in your firewall, you will forward traffic to that custom local IP/port.

If I'm not understanding you correct, DM me on Matrix.

bugbountyguy commented 1 year ago

Hi,

Since I don't have Matrix, thought I'd post one more time real quick before going that route if possible.

Thanks for the response. The server itself was setup on its own port without issues and had been for quite a while. However, I was having an error on the new mobile app that said the url was incorrect (screenshot attached). I changed my internal port forwarding to 443 from the external port, so now I was able to log into the app without issues. However, anyone who might not be able to change the internal port to the app for whatever reason might have issues.

But on my end, no issues and my testing on notifications worked flawlessly. Thank you so much! Cannot wait until you get VoIP / SIP calling to work on this, that'll be super exciting to finally get off Sipnetic. And now I can remove my custom code integration to nextcloud for sms notifcations, so 1 less layer for me :D

For the topic, guess the port parsing for the mobile app is a bug? :)

4d465205-5f77-4126-8db5-5b31a10cb1d5

0perationPrivacy commented 1 year ago

@bugbountyguy I see your issue now. It's a simple fix. we're validating the URL right now with a regex that doesn't allow for port numbers at the end. I'll fix that to allow it. Stay tuned. Thanks for discovering that. I'll close it when it's fixed.

huzaifa3115 commented 1 year ago

Closing this issue, this has been fixed in the latest release v-0.4 https://github.com/0perationPrivacy/VoIPSuite-Mobile/releases/tag/v-0.4