Closed pensierinmusica closed 9 years ago
Should be fixed with the merge of this PR https://github.com/msgpack/msgpack-node/pull/26
new msgpack merged, version bumped to 1.0.0, and pushed to npm
@godsflaw thanks!
zerorpc uses msgpack to be cross-language. This means we cant get rid of msgpack. Its fine switching to a different msgpack implementation if needed though.
The problem seems related to the
msgpack
module. I've opened an issue there too: https://github.com/msgpack/msgpack-node/issues/27What worries me a bit, looking at the other
msgpack
issues is that the build seems to fail on many Node versions: https://github.com/msgpack/msgpack-node/issues/Should this module be swapped for another Node JS version of msgpak, or be substituted entirely with
JSON.stringify
andJSON.parse
? The latter would produce slightly longer strings, but should be way faster with current implementation (as mentioned inmsgpack-node
docs).