search

0rpc / zerorpc-node

zerorpc for node.js
http://www.zerorpc.io
Other
704 stars 166 forks source link

switch zmq -> zeromq, msgpack -> msgpack-lite #84

Closed fyears closed 6 years ago

fyears commented 7 years ago

I was trying zerorpc in Windows, it's VERY annoying to configure the node-gyp / C++ compiler environment.

Then I tried to find the alternatives: zeromq.js is a better alternative to zeromq.node, and most importantly it provides prebuilt binaries for all major platforms! No need to install c++ compilers!

Similarly, msgpack-lite is a pure js alternative to msgpack using c++ codes. It claims to be faster than msgpack.

npm test seems to have no problems.

stanleyxu2005 commented 7 years ago

Sorry. I did not notice that you have provide a PR as well. The only difference between yours and mine, is I have not changed zmq to zeromq. No idea, whether this change is really necessary. zeromq is a new module. I'm not pretty sure there is good reason to switch

fyears commented 7 years ago

zeromq is under more active maintenance, and most importantly it provides pre-compiled binaries under different platforms (especially, Windows!), which means we even don't need a C++ compiler any more if everything goes well.

Under the hook, zmq and zeromq have insignificant differences.

medanat commented 6 years ago

It would be great to get this merged in given zmq is no longer maintained.

dayfine commented 6 years ago

Could someone review and maybe approve this PR?

I have problem getting the origin repo to work, as msgPack throwing me an error about not being able to find its node binding...maybe c++ thing. Solved with this fork.

qyloxe commented 6 years ago

Can this PR be merged? Please? :-) On windows installing zerorpc-node is a nightmare. With this little change to zeromq it just works.

Interesting - Python vs Node benchmark (Windows 7): pyserver <- pyclient (10000 hello requests) = 11 seconds nodeserver <- pyclient (10000 hello requests) = 45 seconds