search

0rpc / zerorpc-node

zerorpc for node.js
http://www.zerorpc.io
Other
707 stars 167 forks source link

emit connect, disconnect events #91

Open dichnd opened 7 years ago

dichnd commented 7 years ago

emit "connect" and "disconnect" event so client can control connect status

bombela commented 7 years ago

are the tests passing for you?

dichnd commented 7 years ago

I have passed all your available tests. I run tests at local, addition you can check in The Travis CI build result. I don't understant the error it notified

bombela commented 7 years ago

It looks like the tests are passing fine, but the test program never terminates. So travis waits 10 minutes then give up. Make sure the test runner is not lingering around after passing the tests. It could be a some scheduled callbacks waiting for something that never happens.

dichnd commented 7 years ago

please help me check my commit. is setTimeout cause the problem. I think i didn't add any new schedule callbacks

bombela commented 7 years ago

I will try to find some time to look into it. No guarantee though.

On Wed, May 31, 2017 at 1:30 PM Dich notifications@github.com wrote:

please help me check my commit. is setTimeout cause the problem. I think i didn't add any new schedule callbacks

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/0rpc/zerorpc-node/pull/91#issuecomment-305307976, or mute the thread https://github.com/notifications/unsubscribe-auth/AANMjHdH564zA-EXPXVm65Ah-wRo9QyHks5r_c31gaJpZM4NsFAF .

mfrye commented 6 years ago

👍

This would be great to have. Apart from the heartbeat error when you try to make a connection and it times out, there's no other notice when the connection is broken...