allow different RPC server for complete quest

0rtis / dfktools

Interact with the contracts of DefiKingdoms

MIT License

127 stars 95 forks source link

allow different RPC server for complete quest #20

Closed neelfirst closed 2 years ago

neelfirst commented 2 years ago

@0rtis please review the proposed change in quest/quest.py. I came across a situation where I wanted to rotate RPCs to avoid failed transactions. Yet the Quest class as structured doesn't allow for rpc_address changes. I've only made the change to complete_quest but if you approve of the design I can propagate throughout the class.

Thanks for your time.

0rtis commented 2 years ago

It doesnt feel right to allow to different RPC just to complete the quest. You could just do quest.rpc_address = 'new rpc' whenever you need to rotate