search

0rtis / dfktools

Interact with the contracts of DefiKingdoms
MIT License
127 stars 97 forks source link

Add optional block_identifier #24

Closed 9-dorf closed 2 years ago

9-dorf commented 2 years ago

Optional block_identifier allows historical data to be read.

thanpolas commented 2 years ago

that's interesting... wasn't it populated by default by the underlying library?

9-dorf commented 2 years ago

Yes, but this allows users to pass in custom block numbers so you look back in time.

thanpolas commented 2 years ago

Yes, but this allows users to pass in custom block numbers so you look back in time.

correct, if that's the use case then yea, this is required.

0rtis commented 2 years ago

Implemented in aa12a6f