search

0rtis / dfktools

Interact with the contracts of DefiKingdoms
MIT License
127 stars 95 forks source link

add crystalvale gardening pool contract address #51

Closed kanasite closed 2 years ago

0rtis commented 2 years ago

Thank you for this. However, it's preferable to have a list of all garden quest rather than a variable for each Feature added in 2bbc62cc91a21acca90756c90a4f0eb74dc0feb5

kanasite commented 2 years ago

Thank you for this. However, it's preferable to have a list of all garden quest rather than a variable for each Feature added in 2bbc62c

Instead of list, perhaps it will be more accessible to place in a dict?

hence user can use the v2 quest and directly CRYSTALVALE_GARDENING_QUEST_CONTRACT_ADDRESS[0] if they going to perform gardening quest on pool 0

I'm happy to drop in a new PR to update the example for V2 gardening on crystalvale

0rtis commented 2 years ago

Luckily, the indexing of the list marches the ids of the pools :) However, it would be better to have a function get_cv_pool_id_contract_address(pool_id) yhat returns the contract address of a given pool id. We could even have a get_cv_liquidity_pair_contract_address(liquidity_pair)

And of course, you are more than welcome to update the garden example