0sc / activestorage-cloudinary-service

MIT License
60 stars 8 forks source link

Version 0.1.0 #1

Closed 0sc closed 6 years ago

0sc commented 6 years ago
0sc commented 6 years ago

Great suggestion, adding active_storage as a dependency. Building on that, I working on building out v0.2 as a rails plugin instead of a standalone gem. That should make it easy to leverage the rails environment.

0sc commented 6 years ago

I was at a loss at how best to go about the specs. Since the class basically forwards communication between active_storage and cloudinary, I try to assuming the two collaborating parties are well tested in themselves and avoid the trap of repeating tests for them.

Instead, I aimed to test that the communication happens between them, hence the heavy reliance on expect(xyz).to have_received ...

Do you think there're possible flaws to this approach?