0sc / course-builder

Automatically exported from code.google.com/p/course-builder
0 stars 0 forks source link

CAN_PERSIST_ACTIVITY_EVENTS parsing conflict with outputHeight #51

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Set the optional outputHeight field in a .js file
2. Turn on CAN_PERSIST_ACTIVITY_EVENTS (set True in utils.py)
3. Visit the Activity

What is the expected output? What do you see instead?
I'd expect the .py parser to parse outputHeight fine.  Instead it crashes when 
py tries to parse the .js Activity.

What version of the product are you using? On what operating system?
1.5.0 on GAE 1.8.1

Please provide any additional information below.
I can fix this by never using outputHeight (no biggy), but I wanted to let you 
know their is a bug.  Here is the Trace...

Traceback (most recent call last):
  File "C:\Program Files (x86)\Google\google_appengine\lib\webapp2-2.5.2\webapp2.py", line 1535, in __call__
    rv = self.handle_exception(request, response, e)
  File "C:\Program Files (x86)\Google\google_appengine\lib\webapp2-2.5.2\webapp2.py", line 1529, in __call__
    rv = self.router.dispatch(request, response)
  File "C:\Program Files (x86)\Google\google_appengine\lib\webapp2-2.5.2\webapp2.py", line 1278, in default_dispatcher
    return route.handler_adapter(request, response)
  File "C:\Program Files (x86)\Google\google_appengine\lib\webapp2-2.5.2\webapp2.py", line 1102, in __call__
    return handler.dispatch()
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\controllers\sites.py", line 934, in dispatch
    super(ApplicationRequestHandler, self).dispatch()
  File "C:\Program Files (x86)\Google\google_appengine\lib\webapp2-2.5.2\webapp2.py", line 572, in dispatch
    return self.handle_exception(e, self.app.debug)
  File "C:\Program Files (x86)\Google\google_appengine\lib\webapp2-2.5.2\webapp2.py", line 570, in dispatch
    return method(*args, **kwargs)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\controllers\sites.py", line 1072, in get
    handler.get()
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\controllers\lessons.py", line 377, in get
    student, unit_id, lesson_id)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\models\progress.py", line 355, in put_activity_accessed
    if not self.get_valid_block_ids(unit_id, lesson_id):
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\models\progress.py", line 154, in get_valid_block_ids
    activity = self.get_activity_as_python(unit_id, lesson_id)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\models\progress.py", line 97, in get_activity_as_python
    content, root_name, verify.Activity().scope, noverify_text)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\tools\verify.py", line 969, in evaluate_python_expression_from_text
    restricted_scope = parse_content(content, scope, root_name)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\models\content.py", line 416, in parse_string_in_scope
    return parser.parse_string_in_scope(content, scope, root_name)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\models\content.py", line 386, in parse_string_in_scope
    {root_name: cls.parse_string(content).asList()}.items())
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\models\content.py", line 376, in parse_string
    return cls.activity_grammar.parseString(content)
  File "C:\Rose\ME430\trunk\videoWebsite\coursebuilder\lib\pyparsing-1.5.7.zip\pyparsing.py", line 1006, in parseString
    raise exc
ParseException: Expected "]" (at char 2021), (line:60, col:5)

progress.py
        if not self.get_valid_block_ids(unit_id, lesson_id):
            self.put_activity_completed(student, unit_id, lesson_id)

Original issue reported on code.google.com by fisherds on 30 Jul 2013 at 3:24