0to9Digital / SEO-Lite-Pro

The most powerfull SEO module for ExpressionEngine.
6 stars 6 forks source link

SEO lite upgrade - causing multiple tabs to get added #6

Closed dankingsley closed 2 years ago

dankingsley commented 2 years ago

When upgrading from SEO v1 to v2 of EE5, all the tabs get messed up as part of the upgrade. It seems to be adding tabs to the layout for each section - see image:

Screenshot 2022-02-03 at 13 47 17

.

0to9Digital commented 2 years ago

Hi @dankingsley Which version of EE5 do you use?

dankingsley commented 2 years ago

Hi, the latest version 5.4.3...

0to9Digital commented 2 years ago

It looks like the code from upd.seo_lite.php isn't correct, can you remove the lines 419 till 490 and try again: Example of removing code:

// Add SEO Lite (v2) tab fields
            $seolite_tabs = array(
                'seo_lite_robots_directive' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_og_title' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_og_type' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_og_description' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_og_url' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_og_image' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_twitter_title' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_twitter_type' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_twitter_description' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_twitter_type' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
                'seo_lite_twitter_image' => array(
                    'visible'    => 'true',
                    'collapse'    => 'false',
                    'htmlbuttons'    => 'false',
                    'width'        => '100%',
                ),
            );

            $this->EE->load->library('layout');
            $this->EE->layout->add_layout_fields($seolite_tabs, 'seo_lite');
dankingsley commented 2 years ago

Yep, great that seems to fix things. Thanks.

adster101 commented 2 years ago

I've removed the code as indicated above but I still get the extra tabs. This is on both ee6 and ee5. Do I need to uninstall first then reinstall?

dorothyDorothy commented 2 years ago

I've got this problem too but I'm able to roll the installation back. Does this mean that it needs to be uninstalled first?

dorothyDorothy commented 2 years ago

It looks like a language file issue? The fix indicated above on the 3rd February did not help.

0to9Digital commented 2 years ago

Please roll the installation back. Version 2.0.5 fixes the issue.

dorothyDorothy commented 2 years ago

To roll back should I

  1. uninstall
  2. Delete plug-in code
  3. Delete SEO tables?

I notice that if I do the first 2 actions of those 3, I can still see the broken tabs in some of my channel entries.