0vercl0k / rp

rp++ is a fast C++ ROP gadget finder for PE/ELF/Mach-O x86/x64/ARM/ARM64 binaries.
MIT License
1.78k stars 251 forks source link

Disable colorizing the output if stdout isn't a terminal. #4

Closed jcande closed 9 years ago

jcande commented 9 years ago

In the case where you redirect output (./rp | vi -) the color escape sequences won't appear. I haven't attempted to compile this on Windows. I also wasn't able to test the patch (but I did test it out on the master branch, which I'll submit shortly).

Let me know what you think. Thanks!

0vercl0k commented 9 years ago

Awesome Jared -- thank you! I'll try that today :=)

Cheers, 0vercl0k

2015-01-25 6:29 GMT+00:00 Jared Candelaria notifications@github.com:

In the case where you redirect output (./rp | vi -) the color escape sequences won't appear. I haven't attempted to compile this on Windows. I also wasn't able to test the patch (but I did test it out on the master branch, which I'll submit shortly).

Let me know what you think. Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/0vercl0k/rp/pull/4 Commit Summary

  • Disable colorizing the output in the cases where the output isn't

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/0vercl0k/rp/pull/4.