Add OpenBSD support

[jasperla]

With these changes I can run rp++ on OpenBSD.

[0vercl0k]

Woot, awesome! Thanks for sending this in - just a quick question; any reason to remove the std::abort? (and sorry for the lag!)

Cheers

[jasperla]

The reason I removed the abort() call was because it seems the original intent was to return the "unknown type" message all along. Otherwise either the abort() or "unknown type" message should be removed as not both could be executed. I figured it's more helpful to print an informative message instead of crashing :-)

[0vercl0k]

Haha yeah it looks a bit funky - I think the reason is that I needed to return an std::string to make the compiler happy but wanted to abort at runtime. The goal was to be noisy about processing files w/ segments that I didn't know about so that folks can let me know.

Do you mind reverting that bit? I don't think it's a big deal but ideally I'd like to keep the same behavior as before :)

Cheers

On Mon, Nov 27, 2023 at 9:39 PM Jasper Lievisse Adriaanse < @.***> wrote:

The reason I removed the abort() call was because it seems the original intent was to return the "unknown type" message all along. Otherwise either the abort() or "unknown type" message should be removed as not both could be executed. I figured it's more helpful to print an informative message instead of crashing :-)

— Reply to this email directly, view it on GitHub https://github.com/0vercl0k/rp/pull/55#issuecomment-1828563936, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALIOROGUUBRSXKOIQZHNU3YGT265AVCNFSM6AAAAAA7JHLOMKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRYGU3DGOJTGY . You are receiving this because you commented.Message ID: @.***>

[0vercl0k]

Thank you again 🙏!

[jasperla]

Thanks for the merge and the abort() touch-up!