0x00000002 / rootcore

Apache License 2.0
0 stars 1 forks source link

event and function names must be different #14

Open gabriel-canaan opened 6 years ago

gabriel-canaan commented 6 years ago

rootcore/blob/master/contracts/ERC20Token.sol Line 44

  function transfer(address _to, uint256 _value)
        public
        validAddress(_to)
        returns (bool success)
    {
        balanceOf[msg.sender] = safeSub(balanceOf[msg.sender], _value);
        balanceOf[_to] = safeAdd(balanceOf[_to], _value);
        Transfer(msg.sender, _to, _value);
        return true;
    }

rootcore/blob/master/contracts/Pausable.sol Line 34,43

function pause() managerOnly whenNotPaused returns (bool) {
    paused = true;
    Pause();
    return true;
  }
  function unpause() managerOnly whenPaused returns (bool) {
    paused = false;
    Unpause();
    return true;
  }
gabriel-canaan commented 6 years ago

Favor capitalization and a prefix in front of events (we suggest Log), to prevent the risk of confusion between functions and events