0x00000002 / rootcore

Apache License 2.0
0 stars 1 forks source link

visibility is not specified, default to public #3

Open gabriel-canaan opened 6 years ago

gabriel-canaan commented 6 years ago

rootcore/blob/master/contracts/helpers/Migrations.sol Line 12

    function Migrations() {
        owner = msg.sender;
    }

rootcore/blob/master/contracts/CrowdsaleController.sol Line 57

function CrowdsaleController(uint256 _startTime, address _beneficiary)
SmartTokenController(new SmartToken(TOKEN_NAME, TOKEN_SYM, TOKEN_DEC))
validAddress(_beneficiary)
earlierThan(_startTime)
{
gabriel-canaan commented 6 years ago

rootcore/blob/master/contracts/ERC20Token.sol Line 27

  function ERC20Token(string _name, string _symbol, uint8 _decimals) {
        require(bytes(_name).length > 0 && bytes(_symbol).length > 0); // validate input

        name = _name;
        symbol = _symbol;
        decimals = _decimals;
    }

rootcore/blob/master/contracts/Managed.sol Line 15

 function Managed() {
        manager = msg.sender;
    }

rootcore/blob/master/contracts/Owned.sol Line 16

  function Owned() {
        owner = msg.sender;
    }

rootcore/blob/master/contracts/SmartToken.so Line 31

  function SmartToken(string _name, string _symbol, uint8 _decimals)
        ERC20Token(_name, _symbol, _decimals)
    {
        NewSmartToken(address(this));
    }

rootcore/blob/master/contracts/SmartTokenController.sol Line 27

  function SmartTokenController(ISmartToken _token)
        validAddress(_token)
    {
        token = _token;
    }

[rootcore/blob/master/contracts/TokenHolder.sol] (https://github.com/tikonoff/rootcore/blob/master/contracts/TokenHolder.sol) Line 18

rootcore/blob/master/contracts/Utils.so Line 10

  function Utils() {
    }
gabriel-canaan commented 6 years ago

we consider it good practice to always declare the type access to your methods. See: view and pure