search

0x00000002 / staking-app

MIT License
0 stars 0 forks source link

Differentiate functions and events #3

Open ryu9827 opened 6 years ago

ryu9827 commented 6 years ago

https://github.com/tikonoff/staking-app/blob/8306bb8deebe0f554e99bf4e525ea4a3f5672397/contracts/Stake.sol#L24 Favor capitalization and a prefix in front of events (we suggest Log), to prevent the risk of confusion between functions and events:

  event LogStakeEvent(address indexed user, uint levs, uint startBlock, uint endBlock);
  event LogRedeemEvent(address indexed user, uint levs, uint feeEarned, uint startBlock, uint endBlock);
  event LogFeeCalculated(uint feeCalculated, uint feeReceived, uint weiReceived, uint startBlock, uint endBlock);
  event LogStakingInterval(uint startBlock, uint endBlock);