search

0x00000002 / staking-app

MIT License
0 stars 0 forks source link

Redundant syntax is used #6

Closed ryu9827 closed 6 years ago

ryu9827 commented 6 years ago

https://github.com/tikonoff/staking-app/blob/8306bb8deebe0f554e99bf4e525ea4a3f5672397/contracts/HumanStandardToken.sol#L54

According to Solidity 0.4.20 documentation, it should be (delete byte32):

require(_spender.call(bytes4(keccak256("receiveApproval(address,uint256,address,bytes)")), msg.sender, _value, this, _extraData));
ryu9827 commented 6 years ago

Consider to remove this function because it makes customers confused when they look at it. And whatever you enter as input variables, it always returns 'true', which makes this function meaningless.

ryu9827 commented 6 years ago

Has been combined into #5