0x002A / MuCHSALSA

Multi-Core Hybrid Short- And Long-read Sequence Assembler
GNU General Public License v3.0
7 stars 1 forks source link

Pipeline improvements #13

Closed xileF1337 closed 1 year ago

xileF1337 commented 1 year ago

This PR contains several improvements to the LazyB/MuCHSALSA pipeline. Changes include:

xileF1337 commented 1 year ago

@TGatter, would you be so kind as to review and merge? Thank you so much!

0x002A commented 1 year ago

Thanks for the PR.

But before @TGatter merges, I'd like to give it a short review too. 😀

xileF1337 commented 1 year ago

Sure, you're very welcome. My reference to Thomas was mainly due to the fact that I discussed those things with him already.

xileF1337 commented 1 year ago

And just for clarification, this PR only contains technical improvements to the pipeline scripts, and no improvements to the actual assembly process. Thomas has to decide what exactly we will do about that.

0x002A commented 1 year ago

Only a single remark/question otherwise it lgtm. Will approve after clarification.

Nice code quality, good job

xileF1337 commented 1 year ago

Only a single remark/question otherwise it lgtm. Will approve after clarification.

Nice code quality, good job

Thanks for the review, @0x002A ! I commented on the Cmake version requirement in your remark above. Looking forward for the merge!

TGatter commented 1 year ago

You may go ahead an merge. I approve of the pipeline changes.

0x002A commented 1 year ago

Your wish is my command.